Invalid#11025
Closed
DragonFSKY wants to merge 2 commits into
Closed
Conversation
A generated target zip file name can contain path segments such as "../". For FILE results, ZipTransformer resolves that name against workDirectory and writes the zip file there, which allows the output file to be created outside the configured work directory. Add an opt-in keepWorkingDirectory flag to reject target zip file names whose canonical path is outside workDirectory. Keep the default false to preserve existing behavior for applications that rely on the current path handling. Also expose the option in the XML namespace and cover the default behavior, valid in-directory output, and rejected traversal attempts with tests. Fixes: spring-projectsgh-10964 Signed-off-by: Dongliang Xie <dragonfsky@gmail.com>
Document the new ZipTransformer keepWorkingDirectory option in the zip reference and add it to the 7.1 what's-new section. Signed-off-by: Dongliang Xie <dragonfsky@gmail.com>
DragonFSKY
force-pushed
the
fix/10964-zip-transformer-work-directory
branch
from
0c35c38 to
b831412
Compare
Contributor
|
Thank you for your contribution! I've been revisiting the original issue, and it is a bit vague. For now, I'm closing it so we can better articulate how EIP should handle this scenario. |
artembilan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.