Skip to content

Fix misleading Javadoc for messaging annotation post-processors#11020

Merged
artembilan merged 2 commits into
spring-projects:mainfrom
mjd507:annotation-post-processor
May 27, 2026
Merged

Fix misleading Javadoc for messaging annotation post-processors#11020
artembilan merged 2 commits into
spring-projects:mainfrom
mjd507:annotation-post-processor

Conversation

@mjd507
Copy link
Copy Markdown
Contributor

@mjd507 mjd507 commented May 25, 2026

The MessagingAnnotationPostProcessor is really not a BeanPostProcessor.

Also, update the Javadocs to describe MessagingAnnotationPostProcessor and MessagingAnnotationBeanPostProcessor as handling @Bean methods and regular component methods, respectively.

The `MessagingAnnotationPostProcessor` is really not a `BeanPostProcessor`.

Also, update the Javadocs to describe `MessagingAnnotationPostProcessor` and `MessagingAnnotationBeanPostProcessor` as handling `@Bean` methods and regular component methods, respectively.

Signed-off-by: Jiandong Ma <jiandong.ma.cn@gmail.com>
@artembilan artembilan added this to the 7.1.0 milestone May 26, 2026
cppwfs
cppwfs previously requested changes May 26, 2026
Copy link
Copy Markdown
Contributor

@cppwfs cppwfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contributions,
I made a couple of small requests for your review.

@cppwfs cppwfs dismissed their stale review May 26, 2026 18:07

Duplicate of @artembilan 's review

@mjd507
Copy link
Copy Markdown
Contributor Author

mjd507 commented May 26, 2026

thank you all!

Btw, I have another query:

should we provide option to skip this two post processors, since nowadays user may use DSL only.

May be it would be a little improvement for performance.

@artembilan
Copy link
Copy Markdown
Member

should we provide option to skip this two post processors, since nowadays user may use DSL only.

that’s interesting idea!
Let’s create an issue to track that down !
Perhaps something like @EnableIntegration(parseAnnotations = false) would do the trick 😅

@mjd507
Copy link
Copy Markdown
Contributor Author

mjd507 commented May 27, 2026

that’s interesting idea! Let’s create an issue to track that down !

sure. created: #11024

Signed-off-by: Jiandong Ma <jiandong.ma.cn@gmail.com>
@artembilan artembilan merged commit 394ab11 into spring-projects:main May 27, 2026
3 checks passed
@mjd507 mjd507 deleted the annotation-post-processor branch May 27, 2026 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants