Conversation
DocumentRowMapper.mapRow() always wrote the computed similarity distance into the metadata map under the key `distance`, overwriting any document that already used that key. The same value is already available via `Document#getScore()`, making the write redundant. Skip the write and log a warning when the key is already present, so existing metadata survives. Signed-off-by: Srinadh Bhattiprolu <ss.bhattiprolu@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DocumentRowMapper.mapRow()always wrote the computed similarity distance into the metadatamap under the key
distance, overwriting any document that already used that key for its owndata.
Documentalready exposes the same value viagetScore(), so the write was redundant.Skip the write and log a warning when the key is already present, so existing metadata survives.
Testing
Added
rowMapperSkipsDistanceMetadataWhenUserAlreadyUsesThatKey, which fails without the fix(returns the computed distance instead of the caller's value) and passes with it, plus
rowMapperAddsDistanceMetadataWhenAbsentcovering the normal case../mvnw -pl vector-stores/spring-ai-pgvector-store testpasses (28 tests). Spring Java Formatand Checkstyle ran as part of that build with no violations.