Handle JSON null string while using structured output validation - #6977
Open
nicolaskrier wants to merge 1 commit into
Open
nicolaskrier wants to merge 1 commit into
nicolaskrier wants to merge 1 commit into
Conversation
Signed-off-by: Nicolas Krier <7557886+nicolaskrier@users.noreply.github.com>
Contributor
Author
|
I figured out that I had to modify the system prompt to have |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I noticed that structured output validation fails when a model emits "null" as its JSON output. These changes handle a null JSON node as a passed validation instead of triggering unnecessary retries.
Reproduction
I performed some successful tests of these changes with my tools example by using Ollama and Mistral AI model providers. As a first step, I applied #6974 fix. You can find below screenshots of what I observed on Phoenix.
Behavior of my tools example before the fix with Ollama
Behavior of my tools example after the fix with Ollama
Behavior of my tools example before the fix with Mistral AI
Behavior of my tools example after the fix with Mistral AI
Testing
I added a unit test in
StructuredOutputValidationAdvisorTestsclass.Notes