Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maintainer said
jbetancur, 2026-09-22T11:16:48Z, on
CHANGELOG.mdline 21 (jbetancur#1394 (comment)):Context: v8.10.0 was tagged on 2026-09-06 (
a3473b0 chore: release v8.10.0 [skip ci]). At the submitted head 92f7524 the bullet for this fix sat under## 8.10.0 / ### Bug fixes, i.e. inside a section that has already shipped.Change
CHANGELOG.md:5-12(one commit, 63253d8,docs: file the pinned scrollbar fix under a new 8.10.1 changelog entry): a new## 8.10.1section with its own### Bug fixesheading and---separator is inserted above## 8.10.0, in the file's existing format; the bullet moves there unchanged, and the## 8.10.0section is restored byte-for-byte to upstream master. No other file changes in this round.Diff of
CHANGELOG.mdagainst upstreammaster(424d21c) at this head:Evidence, using the exact
awkthe release workflow runs to extract release notes (.github/workflows/release.yml:101):So before the change, a future
8.10.1release would have extracted empty notes and the bullet would have been misfiled under a shipped version; after it, the 8.10.1 extraction yields exactly this bullet and the 8.10.0 section is the released one.Branch diff against upstream master at this head:
CHANGELOG.md +8,CLAUDE.md(pre-existing, merge-base drift: upstream jbetancur#1395 changed the same line after our branch point),src/__tests__/pinning.test.tsx +193,src/components/PinnedScrollbar.tsx +6/-1. OnlyCHANGELOG.mddiffers from the submitted head 92f7524.CI chain (
npm run lint && npm run typecheck && npm test && npm run build, as.github/workflows/ci.ymlruns it): see## CIbelow.CI
Local run of the exact chain
.github/workflows/ci.ymlexecutes (npm ci,npm run lint,npm run typecheck,npm testscoped to the touched test file,npm run build) at 63253d8, Node v24.19.0 (log:/agent-output/oss/react-data-table-component/r1-ci-chain.log):Nothing in
eslint.config.js,tsconfig.json,tsup.config.tsorvitest.config.tsreadsCHANGELOG.md, so the only tool that consumes it is the release workflow'sawkextraction shown above. Fork CI:gh pr checks 2reports no checks (the fork'sci.ymltriggers onpull_requesttomasteronly, and this staging PR targets the feature branch; upstream CI at 92f7524 was already green after the previous round). Upstream CI at the new head will run once the Scout fast-forwards the submitted branch; the maintainer must approve the fork workflow as before.Reply
Moved the entry into a new
## 8.10.1section above## 8.10.0in 63253d8, with its own### Bug fixesheading in the file's format. The## 8.10.0section is now identical to master again, and the release workflow's notes extraction for8.10.1returns just this bullet.