Repository navigation
Add maxConnections to JdbcConnectionOptions - #6022
Open
Manishram-ai wants to merge 1 commit into
Open
Manishram-ai wants to merge 1 commit into
Manishram-ai wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4047
The JDBC reads and writes use a connection pool that only allows 8 connections per worker by default. If more threads than that try to write at the same time, the rest just wait for a free connection forever, which is why the pipeline in the issue got stuck.
Beam added a setting for this in 2.45 (apache/beam#21200), so this PR exposes it as an optional
maxConnectionsfield onJdbcConnectionOptions. It'sNoneby default, so nothing changes for existing users.I also added a test and a short note in the JDBC docs. Tests pass on Scala 2.13 and 2.12.