Repository navigation
Fix IcebergIOIT implicit ambiguity; compile integration tests on PR builds - #6001
Merged
Merged
Conversation
clairemcginty
approved these changes
Sep 17, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6001 +/- ##
=======================================
Coverage 61.99% 61.99%
=======================================
Files 323 323
Lines 11743 11743
Branches 839 839
=======================================
Hits 7280 7280
Misses 4463 4463 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IcebergIOIT— excluderfLocalDateTimeMicrosfrom thetimestamp.microswildcard import since IcebergIO needsSqlTypes.DATETIME(millis grouping) for unzoned timestamps, not rawINT64integration/Test/compileto the CI build postamble so integration test compilation errors are caught on PR builds, not only after merge to mainContext
After merging #6000 (magnolify 0.9.8 +
timestamp.micros._), CI failed on main with an ambiguous implicit: the wildcardimport timestamp.micros._bringsrfLocalDateTimeMicros(raw INT64) into scope alongside the explicitlocalDateTimeRowField(SqlTypes.DATETIME) in the companion object. Both provideRowField[LocalDateTime].The root cause is an axis mismatch: magnolify groups implicits by precision (
millis/micros/nanos), but IcebergIO consumes by logical type —InstantneedsTimestamp.MICROS(frommicros) whileLocalDateTimeneedsSqlTypes.DATETIME(frommillis). A single wildcard import can't serve both.This wasn't caught on the PR because integration test compilation was only running on main, not on PRs.
Changes
IcebergIOIT.scala— excluderfLocalDateTimeMicrosfrom the wildcard import; added comment explaining the precision/logical-type mismatchbuild.sbt— addintegration/Test/compiletogithubWorkflowBuildPostamble.github/workflows/ci.yml— regenerated (adds "Compile integration tests" step to all build matrix entries)Test plan
IcebergIOITpasses locally (both tests, full Iceberg REST catalog round-trip)