Skip to content

Fix IcebergIOIT implicit ambiguity; compile integration tests on PR builds - #6001

Merged
shnapz merged 1 commit into
mainfrom
akabas/fix-master-it-tests
Sep 17, 2026
Merged

shnapz merged 1 commit into
mainfrom
akabas/fix-master-it-tests

Conversation

@shnapz

@shnapz shnapz commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator
  • Fix ambiguous implicit in IcebergIOIT — exclude rfLocalDateTimeMicros from the timestamp.micros wildcard import since IcebergIO needs SqlTypes.DATETIME (millis grouping) for unzoned timestamps, not raw INT64
  • Add integration/Test/compile to the CI build postamble so integration test compilation errors are caught on PR builds, not only after merge to main

Context

After merging #6000 (magnolify 0.9.8 + timestamp.micros._), CI failed on main with an ambiguous implicit: the wildcard import timestamp.micros._ brings rfLocalDateTimeMicros (raw INT64) into scope alongside the explicit localDateTimeRowField (SqlTypes.DATETIME) in the companion object. Both provide RowField[LocalDateTime].

The root cause is an axis mismatch: magnolify groups implicits by precision (millis/micros/nanos), but IcebergIO consumes by logical type — Instant needs Timestamp.MICROS (from micros) while LocalDateTime needs SqlTypes.DATETIME (from millis). A single wildcard import can't serve both.

This wasn't caught on the PR because integration test compilation was only running on main, not on PRs.

Changes

  1. IcebergIOIT.scala — exclude rfLocalDateTimeMicros from the wildcard import; added comment explaining the precision/logical-type mismatch
  2. build.sbt — add integration/Test/compile to githubWorkflowBuildPostamble
  3. .github/workflows/ci.yml — regenerated (adds "Compile integration tests" step to all build matrix entries)

Test plan

  • IcebergIOIT passes locally (both tests, full Iceberg REST catalog round-trip)
  • CI green on PR (including the new integration compile step)

@shnapz
shnapz merged commit 22d8d8e into main Sep 17, 2026
9 of 10 checks passed
@shnapz
shnapz deleted the akabas/fix-master-it-tests branch September 17, 2026 22:05
@codecov

codecov Bot commented Sep 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.99%. Comparing base (7216c31) to head (3ed6e93).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6001   +/-   ##
=======================================
  Coverage   61.99%   61.99%           
=======================================
  Files         323      323           
  Lines       11743    11743           
  Branches      839      839           
=======================================
  Hits         7280     7280           
  Misses       4463     4463           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants