Repository navigation
Conversation
nicklasl
marked this pull request as ready for review
October 2, 2026 06:24
vahidlazio
reviewed
Oct 7, 2026
| } | ||
|
|
||
| private fun Number.toConfidenceValue(): ConfidenceValue = when (this) { | ||
| private const val MAX_EXACT_DOUBLE_INTEGER = 9_007_199_254_740_992L |
vahidlazio
reviewed
Oct 7, 2026
| is Long -> if (this in Int.MIN_VALUE..Int.MAX_VALUE) { | ||
| ConfidenceValue.Integer(toInt()) | ||
| } else { | ||
| } else if (this in -MAX_EXACT_DOUBLE_INTEGER..MAX_EXACT_DOUBLE_INTEGER) { |
Collaborator
There was a problem hiding this comment.
could be like int, in double.min value .. double.max value
vahidlazio
previously approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Value.Longin context and tracking data without silently losing integer precision.