Fix external images when local media caching is disabled - #563
Closed
brozkeff wants to merge 1 commit into
Closed
Conversation
When DokuWiki's fetchsize disables external media caching, retain the original remote URL instead of falling back to the wrapped fetch.php URL. Pass the resolved target through both mPDF asset path arguments.
Owner
|
no. the issue is that media_get_from_URL() doesn't do what it says when fetch size is 0. you pass the URL on to mpdf which just hands it back to us to be downloaded. all that is needed is to internally set fetchsize here and make the code work as intended. |
Author
|
OK, I already see the the proper path at #564 and can confirm that PR works fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This restores the fallback behavior lost during the mPDF 8.2 migration.
Fixes #562.
Developed and diagnosed with assistance from GPT-5.6-sol.
Test plan
fetchsize = 0.