Switch rustls crypto provider from ring to aws-lc-rs - #3654
Draft
ChihweiLHBird wants to merge 1 commit into
Draft
Conversation
Install aws-lc-rs as the process-wide provider at startup. ring is still compiled via transitive rustls features; removing it is a follow-up. Since both provider features are now enabled, rustls auto-detection would panic on paths that bypass Spin's entrypoints. Replace the install helper with spin_tls::get_or_install_default_crypto_provider(), which returns the installed default - respecting a provider installed by embedders (the old helper would panic) - and installs aws-lc-rs if none is set. The outbound client and trigger-http server TLS configs now build with this provider explicitly. Signed-off-by: Zhiwei Liang <zhiwei.liang@zliang.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Install aws-lc-rs as the process-wide provider at startup. ring is still compiled via transitive
rustlsfeatures; removing it is a follow-up.Since both provider features are now enabled,
rustlsauto-detection would panic on paths that bypass Spin's entrypoints. Replace the install helper withspin_tls::get_or_install_default_crypto_provider(), which returns the installed default - respecting a provider installed by embedders (the old helper would panic) - and installs aws-lc-rs if none is set. The outbound client andtrigger-httpserver TLS configs now build with this provider explicitly.Partially fix #3502