Skip to content

feat(attachments): add heic/heif thumbnail support#8247

Open
grantfitzsimmons wants to merge 1 commit into
mainfrom
issue-8246
Open

feat(attachments): add heic/heif thumbnail support#8247
grantfitzsimmons wants to merge 1 commit into
mainfrom
issue-8246

Conversation

@grantfitzsimmons

@grantfitzsimmons grantfitzsimmons commented Jul 2, 2026

Copy link
Copy Markdown
Member

Fixes #8246

Requires the server to support it, so test alongside specify/web-asset-server#44

image image

If this branch is used with the current v2.0 asset server, it will show a broken image link:

image

Testing instructions

This will likely need to be developer tested, as it requires both the Specify 7 instance to be running this branch (issue-8246) and the asset server to be using branch/Docker tag issue-44.

Compare against a production instance using the latest tagged asset server.

  • Upload a HEIC attachment
  • Verify that a thumbnail displays
  • Upload a HEIF attachment
  • Verify that a thumbnail displays
  • Upload at least one of each and verify thumbnails display properly:
    • GIF
    • PNG
    • TIFF
    • PDF
  • Upload text files, videos, and sounds and verify all appear as expected

@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 8865bd11-9849-40cd-8b13-747ddbb68acb

📥 Commits

Reviewing files that changed from the base of the PR and between f8f5da5 and 7772b88.

📒 Files selected for processing (1)
  • specifyweb/frontend/js_src/lib/components/Attachments/attachments.ts
👮 Files not reviewed due to content moderation or server errors (1)
  • specifyweb/frontend/js_src/lib/components/Attachments/attachments.ts

📝 Walkthrough

[!WARNING]

Walkthrough skipped

File diffs could not be summarized.

🚥 Pre-merge checks | ❌ 2

❌ Failed checks (2 inconclusive)

Check name Status Explanation Resolution
Automatic Tests ❓ Inconclusive Custom check execution failed before a final verdict was produced. Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Testing Instructions ❓ Inconclusive Custom check execution failed before a final verdict was produced. Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch issue-8246

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@grantfitzsimmons grantfitzsimmons marked this pull request as ready for review July 2, 2026 04:13
@grantfitzsimmons grantfitzsimmons added this to the 7.12.1 milestone Jul 2, 2026
@grantfitzsimmons grantfitzsimmons changed the title feat: add heic/heif thumbnail support feat(attachments): add heic/heif thumbnail support Jul 2, 2026
@CarolineDenis

Copy link
Copy Markdown
Contributor

@CodeRabbit full review

@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Full review finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 📋Back Log

Development

Successfully merging this pull request may close these issues.

Support HEIC/HEIF thumbnails

2 participants