feat(attachments): add heic/heif thumbnail support#8247
Open
grantfitzsimmons wants to merge 1 commit into
Open
feat(attachments): add heic/heif thumbnail support#8247grantfitzsimmons wants to merge 1 commit into
grantfitzsimmons wants to merge 1 commit into
Conversation
Requires the server to support it, see specify/web-asset-server#44
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
👮 Files not reviewed due to content moderation or server errors (1)
📝 Walkthrough
🚥 Pre-merge checks | ❌ 2❌ Failed checks (2 inconclusive)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
@CodeRabbit full review |
Contributor
✅ Action performedFull review finished. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8246
Requires the server to support it, so test alongside specify/web-asset-server#44
If this branch is used with the current
v2.0asset server, it will show a broken image link:Testing instructions
This will likely need to be developer tested, as it requires both the Specify 7 instance to be running this branch (
issue-8246) and the asset server to be using branch/Docker tagissue-44.Compare against a production instance using the latest tagged asset server.