SPDY fails in node >= 11.1.0

[bhevesi]

Hi,

Couple of short investigation, why SPDY drop error message
//-------------------------------------------------------------------------------------------------------
buffer.js:72
class FastBuffer extends Uint8Array {}
^

RangeError: Invalid typed array length: -104
at new Uint8Array ()
at new FastBuffer (buffer.js:72:1)
at Handle.onStreamRead [as onread] (internal/stream_base_commons.js:121:17)
at Immediate. (/home/bhevesi/node_modules/handle-thing/lib/handle.js:128:16)
at processImmediate (timers.js:632:19)
//-------------------------------------------------------------------------------------------------------
using new version (11) of node.js.

I found that node internal/stream_base_commons.js has been changed in new version but the SPDY dependency ("handle-thing": "^1.2.5") is not properly call it in /lib/handles.js file.

In Node, function onStreamRead(arrayBuffer) called from handles.js via self.onread(uv.UV_EOF, new Buffer(0)) and self.onread(uv.UV_ECONNRESET, new Buffer(0)). So the given two parameters (instead of one) generates error.

In order to eliminate these errors, I had some changes in /lib/handles.js file:
Replaced "self.onread(uv.UV_EOF, new Buffer(0))" to self.onread(new Buffer(0)) and self.onread(uv.UV_ECONNRESET, new Buffer(0)) to self.onread(new Buffer(0))

Looks errors are disappears but more deep investigation required or/and live maintenance of "handle-thing": "^1.2.5" module

Best regards:
Bela

[jacobheun]

We've upgraded spdy to work with node LTS version (6,8,10). This is due to a recent stream change in node 11.1. Handle thing will need to be updated spdy-http2/handle-thing#6.

I did some quick updates to onread to see if I could resolve the problem for the handle-thing 2.0.0 release, but there are other internal stream changes that will need to be taken into account. Read is leveraging the internal stream state, so we'll need to make sure handle thing is managing that as needed.

[bhevesi]

I appreciate Your change, warm welcome and thank You so much!

[bhevesi]

Dear Jacob, Many-many thanks for Your update. I appreciate Your hard work, quick reply, I wish You the best! Have a nice night! Best regards, Bela Jacob Heun <notifications@github.com> ezt írta (időpont: 2018. nov. 8., Cs, 11:05):

…

We've upgraded spdy to work with node LTS version (6,8,10). This is due to a recent stream change in node 11.1. Handle thing will need to be updated spdy-http2/handle-thing#6 <spdy-http2/handle-thing#6>. I did some quick updates to onread to see if I could resolve the problem for the handle-thing 2.0.0 release, but there are other internal stream changes that will need to be taken into account. Read is leveraging the internal stream state, so we'll need to make sure handle thing is managing that as needed. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#350 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABNvj70Ak5SI8gSJrYwJ33ojYqSM3cYUks5utAH7gaJpZM4YNQkE> .

[p3x-robot]

hello,
how are ya? i am not understanding why this bug is closed, when it is not resolved,? we always using the current node version. could you please tell me what is going on? are we waiting for an upstream package to be fixed?

thanks!

[bhevesi]

Hi, You are correct! Apologize, I closed this issue without deep check of compatibility with Node 11.1.0 version, my mistake, sorry for that. I see, further fixes are required. In order to eliminate the current error message, I have changed two lines in handle.js (version 2.0.0) file: 1. line #88: self.onread(uv.UV_EOF, Buffer.alloc(0)) TO self.onread( Buffer.alloc(0)) 2. line #94: self.onread(uv.UV_ECONNRESET, Buffer.alloc(0)) TO self. onread(Buffer.alloc(0)) I don't know how to reopen this issue, may open a new one? What do You think? Best regards, Bela patrikx3 <notifications@github.com> ezt írta (időpont: 2018. nov. 10., Szo, 10:07):

…

hello, how are ya? i am not understanding why this bug is closed, when it is not resolved,? we always using the current node version. could you please tell me what is going on? are we waiting for an upstream package to be fixed? thanks! — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#350 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABNvj_56upWFFVV6YngyIlzn7JqhdhOVks5utpdqgaJpZM4YNQkE> .

[bhevesi]

Dear Jacob, You are correct! Apologize, I closed this issue without deep check of compatibility with Node 11.1.0 version, my mistake, sorry for that. I see, further fixes are required. In order to eliminate the current error message, I have changed two lines in handle.js (version 2.0.0) file: 1. line #88: self.onread(uv.UV_EOF, Buffer.alloc(0)) TO self.onread( Buffer.alloc(0)) 2. line #94: self.onread(uv.UV_ECONNRESET, Buffer.alloc(0)) TO self. onread(Buffer.alloc(0)) I don't know how to reopen this issue, may open a new one? What do You think? Best regards, Bela Jacob Heun <notifications@github.com> ezt írta (időpont: 2018. nov. 8., Cs, 11:05):

…

We've upgraded spdy to work with node LTS version (6,8,10). This is due to a recent stream change in node 11.1. Handle thing will need to be updated spdy-http2/handle-thing#6 <spdy-http2/handle-thing#6>. I did some quick updates to onread to see if I could resolve the problem for the handle-thing 2.0.0 release, but there are other internal stream changes that will need to be taken into account. Read is leveraging the internal stream state, so we'll need to make sure handle thing is managing that as needed. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#350 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABNvj70Ak5SI8gSJrYwJ33ojYqSM3cYUks5utAH7gaJpZM4YNQkE> .

[jacobheun]

Yes, this is still an issue with handle-thing and is being tracked here: spdy-http2/handle-thing#6. The most recent update I did was to get everything working on LTS first.

Reopening this.

[bhevesi]

Thanks again! Do You reopening or me to do it somehow? Jacob Heun <notifications@github.com> ezt írta (időpont: 2018. nov. 11., V, 14:20):

…

Yes, this is still an issue with handle-thing and is being tracked here: spdy-http2/handle-thing#6 <spdy-http2/handle-thing#6>. The most recent update I did was to get everything working on LTS first. Reopening this. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#350 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABNvjysztwVcfdbCawV45PPjvcXElipQks5uuCQggaJpZM4YNQkE> .

[jacobheun]

I've reopened the issue. I'm not sure when I will have time to fix >=11.1.0 support, but I am happy to review any PRs submitted if someone beats me to it!

[bhevesi]

:-) I don not want to beat You, never ever :-) I'm thankful for Your help! Jacob Heun <notifications@github.com> ezt írta (időpont: 2018. nov. 11., V, 14:38):

…

I've reopened the issue. I'm not sure when I will have time to fix >=11.1.0 support, but I am happy to review any PRs submitted if someone beats me to it! — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#350 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABNvj5-VwzxTtxNUl89Qa-6i-ULRxJyzks5uuCg8gaJpZM4YNQkE> .

[p3x-robot]

@bhevesi so are you gonna create a PR to fix this bug or should I do it? Just have to change these 2 lines?