Skip to content

Describe the device approval page in its new consent layout - #135

Open
batuhan wants to merge 1 commit into
mainfrom
device-approval-consent-design
Open

batuhan wants to merge 1 commit into
mainfrom
device-approval-consent-design

Conversation

@batuhan

@batuhan batuhan commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

The device approval page now uses the same consent layout as app sign-in. It says the client "is requesting access to your account", names the signed-in account (with Switch Account in the account menu), shows the code, the Client ID and where the request started, keeps team reach under Team Access and permissions behind Customize Access, and ends with Allow or Deny.

Updates content/(account)/authentication.mdx and content/agents/permissions.mdx, which still described the old page ("Authorize this device", "Customize what this device can do", Approve).

Merge after the monorepo change that ships the new page reaches production.


See it in action
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

It names the signed-in account and the client ID, shows the code to check,
keeps team reach under Team Access and permissions behind Customize Access,
and ends with Allow or Deny.
@indent

indent Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

Issues

1 potential issue found:

  • permissions.mdx line 27 still quotes the old copy: All teams ("Includes teams you join or create later") and No team access ("Sign-in only. This device can't touch any team"). The new page says "including teams you join later" and "Sign-in only. It can't reach any team.", so these quotes won't appear once it ships. Update the quotes or paraphrase without quotation marks.
    Found by Indent Review Agent

↑ Select any checkbox above to have Indent auto-fix the issue

CI Checks

All required CI checks passed on 9b70bd5.

Review agents

Select any unchecked box below to run or rerun that agent.

Found issues (1)
  • Indent Review Agent · Stale team-option quotes left in permissions.mdx
Full results

Indent Review Agent

  • Summary: Stale team-option quotes left in permissions.mdx
  • Last ran on commit: 9b70bd58
  • Latest result
    {
      "summary": "Stale team-option quotes left in permissions.mdx",
      "findings": [
        {
          "fix": "Update line 27 to quote the new copy, for example: **All teams** (\"including teams you join later\"), **Choose teams** with a picker, or **No team access** (\"Sign-in only. It can't reach any team\"). Or paraphrase without quotation marks, the way authentication.mdx does. The **Team Access** heading could also go here so it matches authentication.mdx.",
          "line": 27,
          "path": "content/agents/permissions.mdx",
          "issue": "The PR fixes the \"Customize Access\" label on line 29, but leaves line 27 quoting text from the old device page: All teams (\"Includes teams you join or create later\") and No team access (\"Sign-in only. This device can't touch any team\"). The new layout is on monorepo branch spike/share-oauth (commit 19c982b163 \"Put device approval in the consent design\"). In its apps/my/src/routes/-device-access-selection.tsx the radio hints are now \"including teams you join later\" and \"sign-in only\", and the summary line says \"Works in all your teams, including ones you join later.\" / \"Sign-in only. It can't reach any team.\" The old strings only exist on main's version of the page. Once the new page ships, these quoted strings won't appear anywhere on it.",
          "title": "Team-option quotes on the permissions page are still the old page's strings",
          "severity": "bug"
        }
      ]
    }

@coderabbitai

coderabbitai Bot commented Nov 15, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

Next included review available in 27 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 103 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c131f811-0e13-4eb3-9b78-1c393b23e426
Commits

Reviewing files that changed from the base of the PR and between 68f0886 and 9b70bd5.

Files selected for processing: 2

  • content/(account)/authentication.mdx
  • content/agents/permissions.mdx
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@@ -26,7 +26,7 @@ Interactive approval screens ask for two things: how much the agent may do, and

**Teams.** You pick **All teams** ("Includes teams you join or create later"), **Choose teams** with a picker, or **No team access** ("Sign-in only. This device can't touch any team").

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Bug · Team-option quotes on the permissions page still use the old page's strings

This line still quotes the old device page: "Includes teams you join or create later" and "Sign-in only. This device can't touch any team". The new layout (monorepo apps/my/src/routes/-device-access-selection.tsx) uses "including teams you join later" and "Sign-in only. It can't reach any team." Update the quotes or paraphrase them, as authentication.mdx does.

Found by Indent Review Agent

This branch was successfully deployed

1 active deployment
preview/device-approval-consent-design — 9b70bd58 Deployed Nov 15, 2026 by spacefast[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant