Skip to content

Refresh the CLI reference: -T for --team and the CLI's current commands - #134

Merged
batuhan merged 2 commits into
mainfrom
refresh-generated-reference
Nov 15, 2026
Merged

batuhan merged 2 commits into
mainfrom
refresh-generated-reference

Conversation

@batuhan

@batuhan batuhan commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

The generated CLI reference at /docs/cli/reference/ still listed -o, --team and command names from before CLI 0.9. Someone copying a command from it got a flag the CLI doesn't accept.

What changes

  • generated/cli/index.md is re-exported with docs:export-public --cli-only from the CLI 0.9.0 release (the npm latest), using the product repo's fixed common-flags generator. Only the CLI reference and its manifest entry change. The reference lists exactly the 355 commands 0.9.0 ships, plus oclif's bundled help and autocomplete, and the common flags come from the CLI's own flag definitions (-T, --team, --space, --claim-token, --token). Commands pending release in 0.10.0 are left out until it ships.
  • scripts/verify-public-safety.mjs flagged the shipped --confidential flag of sf oauth-apps create, and OAuth's lowercase "confidential client" type, as release markers. Only those exact spellings are now blanked, case-sensitively, before the marker scan. The test checks that comment banners, dash-wrapped markers, and uppercase banners still fail.

Not in this PR

The error pages and OpenAPI reference still come from the October snapshot. A full export brings them up to date, including the error pages that no longer name WP Cloud, but it does not fit yet:

  • It adds 264 compatibility redirects. That puts the composed Docs routing rules at 2021 static rules against a budget of 1880, and verify:routes stops the build.
  • It adds two setup pages, antigravity and muse, that the setup sidebar doesn't list yet.

Both need their own change.

Checks (local, Bun 1.3.11)

verify:generated, check, validate, build, test:docs, audit, verify:public-safety, verify:prose (clean) and verify:routes all pass. node --test scripts/verify-public-safety.test.mjs: 2 pass, covering five marker forms.

🤖 Generated with Claude Code


Get evidence
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

The generated CLI reference listed `-o, --team` and pre-0.9 command
names. This re-exports only `generated/cli/index.md` from the product
repo, so the common flags come from the CLI's own flag definitions:
`-T, --team`, `--space`, `--claim-token`, and `--token`.

The public-safety check flagged the shipped `--confidential` flag and the
OAuth "confidential client" type as release markers. Flag spellings and
that client type are now blanked before the marker scan, and a test keeps
a real marker in prose failing.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@indent

indent Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

Issues

1 potential issue found:

  • The narrowed regex still blanks --confidential inside an HTML comment opener: the lookbehind allows !, so <!--confidential --> or <!--confidential: launch TBD--> passes the verifier (exit 0) while it fails on main. Only the exact <!--confidential--> in the new test is rejected. The earlier bypasses (--internal only, --do not distribute, word--word) are fixed.
    Found by Indent Review Agent

↑ Select any checkbox above to have Indent auto-fix the issue

CI Checks

All required CI checks passed on bf6592e.

Review agents

Select any unchecked box below to run or rerun that agent.

Found issues (1)
  • Indent Review Agent · `<!--confidential ...-->` still passes the scan
Full results

Indent Review Agent

  • Summary: `<!--confidential ...-->` still passes the scan
  • Last ran on commit: bf6592ed
  • Latest result
    {
      "summary": "`<!--confidential ...-->` still passes the scan",
      "findings": [
        {
          "fix": "Anchor the flag exemption to where a CLI flag can actually start: line start, whitespace, a backtick, `[` or `(`, e.g. `(?<=^|[\\s`\\[(])--(?:\\[no-\\])?confidential(?![\\w-])` with the `m` flag. At minimum add `!` to the lookbehind class. Add `<!--confidential -->` and `<!--confidential: draft-->` to the rejected cases in the test.",
          "line": 132,
          "path": "scripts/verify-public-safety.mjs",
          "issue": "The narrowed regex `(?<![\\w-])--(?:\\[no-\\])?confidential(?![\\w-])` still matches inside an HTML comment opener. In `<!--confidential`, the character before `--` is `!`, so the lookbehind passes. If the next character is not a word character or `-`, the lookahead passes too, and the marker gets blanked. I checked this at bf6592ed: a page containing `<!--confidential -->` or `<!--confidential: launch TBD-->` passes the verifier with exit 0. Only the exact `<!--confidential-->` that the new test covers is rejected. On main both lines fail, so this is still a regression for author notes in HTML comments. My earlier finding about `--internal only`, `--do not distribute` and `word--word` is fixed: the exemption now covers only the confidential flag.",
          "title": "HTML comments starting with `<!--confidential` still bypass the marker scan",
          "severity": "bug"
        }
      ]
    }

@coderabbitai

coderabbitai Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

Next included review available in 28 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 104 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 36aa77b6-2c94-48e8-93d1-77c3c90254c2
Commits

Reviewing files that changed from the base of the PR and between 68f0886 and bf6592e.

Files ignored due to path filters: 2

  • generated/cli/index.md is excluded by !**/generated/**
  • generated/manifest.json is excluded by !**/generated/**
Files selected for processing: 2

  • scripts/verify-public-safety.mjs
  • scripts/verify-public-safety.test.mjs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment thread scripts/verify-public-safety.mjs Resolved
The CLI reference is now exported from the 0.9.0 release with the fixed
common-flags generator, so it lists exactly the commands and flags 0.9.0
ships, plus oclif's bundled `help` and `autocomplete`. The previous export
came from the product repo's main and described commands pending 0.10.0.

The public-safety exemption now blanks only the exact `--confidential`
flag and the lowercase OAuth client type. Comment banners, dash-wrapped
markers, and uppercase banners fail again, and the test checks each.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@spacefast
spacefast Bot temporarily deployed to preview/refresh-generated-reference November 15, 2026 13:50 Inactive
@batuhan
batuhan merged commit dab9c69 into main Nov 15, 2026
7 checks passed

This branch was previously deployed

1 inactive deployment
preview/refresh-generated-reference — bf6592ed Deployed Nov 15, 2026 by spacefast[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant