refactor: drop unread SourceProductMirror fields#159
Open
alukach wants to merge 1 commit into
Open
Conversation
storage_type and is_primary were deserialized but never read — the struct carried an #[allow(dead_code)] to hide them. serde ignores unknown JSON fields by default, so the fields (and the allow) can go. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
Claude finished @alukach's task in 18s —— View job ✅ No blocking issues — safe to merge.
|
|
🚀 Latest commit deployed to https://source-data-proxy-pr-159.source-coop.workers.dev
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
SourceProductMirrorcarriedstorage_typeandis_primaryfields that are deserialized from the API but never read anywhere — which is why the struct needed an#[allow(dead_code)]. Remove both fields and the attribute.Why
serde ignores unknown JSON fields by default, so a struct only needs the fields it actually uses. Dropping the dead fields also lets the
#[allow(dead_code)]go, so the lint stays honest for the rest of the struct.Verification
cargo clippy --target wasm32-unknown-unknownis clean with the allow removed (confirmingconnection_idandprefixare both still used). Full pre-push suite green.Found via ponytail over-engineering audit.
🤖 Generated with Claude Code