Make the cross toolchain optional so runner needs none - #267
Conversation
fredszaq
left a comment
fredszaq
left a comment
There was a problem hiding this comment.
Look good to me appart for the LLM comments on every new function that repeat themselves and don't have much plus value.
Out of curiosity, what is the use case you have we you don't have a toolchain but still want to use the runner to run stuff ?
| pub id: String, | ||
| pub toolchain: ToolchainConfig, | ||
| pub rustc_triple: String, | ||
| /// Cross toolchain used to build and strip for this platform. `None` for a |
There was a problem hiding this comment.
the comments on that file are a bit too much (hello claude, please don't restate the same thing in three places for adding support of and edge case. these comments are just noise at this point)
There was a problem hiding this comment.
yeah, i'll do a chatty comment reduction pass. good call. i may actually pull tract's claude.md in here if you don't mind (or at least the section about chatty comments).
There was a problem hiding this comment.
i don't see a reason not to add a claude.md ^
|
The use case is, build something on gha, run it on a machine that can not run the gha agent. So I have a "sidekick" that runs the agent, which use dinghy to project the bench on the actual target. The sidekick is typically a raspi. |
dinghy runner ships a prebuilt binary over ssh and needs no compiler, linker or sysroot, yet probe() refused to assemble any [platforms.*] without a resolvable toolchain -- remote-only setups had to point toolchain= at an unused toolchain just to get past assembly. Platforms now carry an Option<ToolchainConfig>: a missing or gcc-less toolchain yields a remote-run-only platform, rustc_triple is tracked on its own for device matching, and setup_env/strip degrade (skip / clear error).
756ac6a to
95d2a5f
Compare
2 participants
dinghy runner ships a prebuilt binary over ssh and needs no compiler, linker or sysroot, yet probe() refused to assemble any [platforms.*] without a resolvable toolchain -- remote-only setups had to point toolchain= at an unused toolchain just to get past assembly. Platforms now carry an Option: a missing or gcc-less toolchain yields a remote-run-only platform, rustc_triple is tracked on its own for device matching, and setup_env/strip degrade (skip / clear error).