fix: scope VPC security groups to minimum required ports (#960)#1013
Open
euniceamoni wants to merge 1 commit into
Open
fix: scope VPC security groups to minimum required ports (#960)#1013euniceamoni wants to merge 1 commit into
euniceamoni wants to merge 1 commit into
Conversation
…lug#960) - Move ecs_tasks SG to root module to avoid circular dependencies - ALB SG: restrict egress to container port → ecs_tasks SG only - ecs_tasks SG: egress limited to 5432 (RDS), 6379 (Redis), 443 (AWS APIs) - RDS SG: replace 10.0.0.0/8 ingress with ecs_tasks SG reference, remove broad egress - Redis SG: replace 10.0.0.0/8 ingress with ecs_tasks SG reference, remove broad egress - Add Checkov CI scan job that fails on HIGH/CRITICAL findings before terraform plan
|
@euniceamoni Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #960
Summary
Audits and hardens all VPC security group ingress/egress rules to follow least-privilege per issue #960.
Changes
Architecture change:
ecs_tasksSG moved to rootmain.tfto resolve circular module dependency (ECS↔RDS/Redis). Egress rules added viaaws_security_group_ruleresources.albegress0.0.0.0/0api_container_port→ecs_tasksSG onlyecs_tasksegress0.0.0.0/00.0.0.0/0rdsingress10.0.0.0/8ecs_tasksSG onlyrdsegress0.0.0.0/0redisingress10.0.0.0/8ecs_tasksSG onlyredisegress0.0.0.0/0CI: Added
security-scanjob (Checkov) that runs beforeterraform planand fails on HIGH/CRITICAL findings.Acceptance Criteria
0.0.0.0/0ingress rules except ports 80/443 on the public ALBTesting
terraform validatepasses locally