Repository navigation
Point the CODEOWNERS install rule at scripts/install.sh - #370
Merged
Merged
Conversation
The rule matched /install.sh at the repository root, where no such file exists, so the intended review requirement was never applied. The script lives at scripts/install.sh; match that path instead. Signed-off-by: bfs2021 <101915083+bfs2021@users.noreply.github.com>
codeyevsky
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
.github/CODEOWNERSline 13 listed/install.shunder the release and CI machinery section, but the repository has noinstall.shat its root. Fixes #367.Root cause
The pattern
/install.shonly matches a file at the repository root. The installer lives atscripts/install.sh, so the rule never matched and the extra reviewer requirement for that file was never applied.Fix
Change the pattern to
/scripts/install.sh, which matches the real file and keeps the same owner.Testing
No test suite covers
CODEOWNERS. Verified thatscripts/install.shexists and is executable, and that the old pattern matched no file in the tree. Only the CODEOWNERS rule changed; no Go code or dependencies were touched.