Repository navigation
Refresh the guard binaries before run and sandbox launch an agent - #302
Merged
codeyevsky merged 1 commit intoNov 4, 2026
Merged
Conversation
The installed guard was only refreshed for commands in cliSubcommands, and run and sandbox are left out of that map on purpose so scripts can call them without a terminal. That meant the two commands that actually start an agent against the guard never replaced a stale one after an upgrade. They now refresh the binaries too, without joining the human-only gate. installGoBinaries is a package variable so the test can check this without launching an agent. Fixes solongate#283 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Jai Dhingra <297267163+j-ai-cmd@users.noreply.github.com>
codeyevsky
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #283
Cause
run()inpackages/app/main.goonly callsinstall.InstallGoBinaries()for commands incliSubcommands.runandsandboxare left out of that map on purpose, so scripts can launch an agent without a terminal. The side effect is that the two commands that actually start an agent against the guard never replaced a stale guard binary after an upgrade.Fix
guardRunnerSubcommandsmap withrunandsandbox. They refresh the binaries the same way the human commands do, but stay out of the human-only gate, so scripts keep working.installGoBinariesis now a package variable pointing atinstall.InstallGoBinaries, so the test can check the refresh without launching an agent.How I tested
TestAgentLaunchersRefreshGuardBinaries:run -- claude,run claudeandsandbox 001 claudeall refresh before the command starts, and an unknown command does not. It fails without the fix.go test -count=1 -race ./...andgo vet ./...inpackages/apppass, including the existing human-only gate tests.🤖 Generated with Claude Code