Skip to content

Commit 9551eff

Browse files
authored
Merge pull request #176 from nebulab/kennyadsl/zeitwerk-fixes
Fixes for Zeitwerk
2 parents 4fb8a68 + 329f89d commit 9551eff

5 files changed

Lines changed: 10 additions & 30 deletions

File tree

app/overrides/auth_admin_login_navigation_bar.rb

Lines changed: 0 additions & 10 deletions
This file was deleted.

app/overrides/auth_shared_login_bar.rb

Lines changed: 0 additions & 10 deletions
This file was deleted.

lib/controllers/backend/spree/admin/orders/customer_details_controller_decorator.rb

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
# frozen_string_literal: true
22

3-
Spree::Admin::Orders::CustomerDetailsController.class_eval do
4-
before_action :check_authorization
3+
module Spree::Admin::Orders::CustomerDetailsControllerDecorator
4+
def self.prepended(base)
5+
base.before_action :check_authorization
6+
end
57

68
private
79

@@ -15,4 +17,6 @@ def check_authorization
1517

1618
authorize! action, resource, session[:access_token]
1719
end
20+
21+
Spree::Admin::Orders::CustomerDetailsController.prepend self
1822
end

solidus_auth_devise.gemspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ Gem::Specification.new do |s|
2121
s.require_path = "lib"
2222
s.requirements << "none"
2323

24-
solidus_version = [">= 1.2.0", "< 3"]
24+
solidus_version = [">= 2.6", "< 3"]
2525

2626
s.post_install_message = "
2727
NOTE: Rails 6 has removed secret_token in favor of secret_key_base, which was deprecated in

spec/controllers/spree/products_controller_spec.rb

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,9 @@
1616
allow(controller).to receive(:before_save_new_order)
1717
allow(controller).to receive(:spree_current_user) { user }
1818
allow(user).to receive(:has_spree_role?) { false }
19-
if SolidusSupport.solidus_gem_version < Gem::Version.new('2.5.x')
19+
20+
expect {
2021
get :show, params: { id: product.to_param }
21-
expect(response.status).to eq(404)
22-
else
23-
expect {
24-
get :show, params: { id: product.to_param }
25-
}.to raise_error(ActiveRecord::RecordNotFound)
26-
end
22+
}.to raise_error(ActiveRecord::RecordNotFound)
2723
end
2824
end

0 commit comments

Comments
 (0)