Skip to content

Commit 4fb8a68

Browse files
authored
Merge pull request #170 from aldesantis/bugfix/rails-6-build
Relax sqlite3 dependency for Rails 6 support
2 parents 69c74f8 + 6b2d4c4 commit 4fb8a68

2 files changed

Lines changed: 15 additions & 11 deletions

File tree

Gemfile

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -5,19 +5,23 @@ source "https://rubygems.org"
55
branch = ENV.fetch('SOLIDUS_BRANCH', 'master')
66
gem "solidus", github: "solidusio/solidus", branch: branch
77

8-
group :test do
9-
if branch == 'master' || branch >= "v2.0"
10-
gem 'rails-controller-testing', '~> 1.0'
11-
else
12-
gem "rails_test_params_backport"
13-
end
8+
# Needed to help Bundler figure out how to resolve dependencies,
9+
# otherwise it takes forever to resolve them
10+
if branch == 'master' || Gem::Version.new(branch[1..-1]) >= Gem::Version.new('2.10.0')
11+
gem 'rails', '~> 6.0'
12+
else
13+
gem 'rails', '~> 5.0'
14+
end
1415

15-
gem 'factory_bot', (branch < 'v2.5' ? '4.10.0' : '> 4.10.0')
16+
group :test do
17+
gem 'rails-controller-testing', '~> 1.0'
18+
gem 'factory_bot', '> 4.10.0'
1619
end
1720

18-
if ENV['DB'] == 'mysql'
21+
case ENV['DB']
22+
when 'mysql'
1923
gem 'mysql2', '~> 0.4.10'
20-
else
24+
when 'postgres'
2125
gem 'pg', '~> 0.21'
2226
end
2327

solidus_auth_devise.gemspec

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ Gem::Specification.new do |s|
4242
s.add_development_dependency "ffaker"
4343
s.add_development_dependency "gem-release", "~> 2.0"
4444
s.add_development_dependency "github_changelog_generator", "~> 1.14"
45-
s.add_development_dependency "rspec-rails", "~> 3.3"
45+
s.add_development_dependency "rspec-rails", "~> 4.0.0.beta2"
4646
s.add_development_dependency "rubocop", "~> 0.71"
4747
s.add_development_dependency "rubocop-performance", "~> 1.4"
4848
s.add_development_dependency "rubocop-rails", "~> 2.2"
@@ -52,5 +52,5 @@ Gem::Specification.new do |s|
5252
s.add_development_dependency "simplecov", "~> 0.14"
5353
s.add_development_dependency "solidus_backend", solidus_version
5454
s.add_development_dependency "solidus_frontend", solidus_version
55-
s.add_development_dependency "sqlite3", "~> 1.3.6"
55+
s.add_development_dependency "sqlite3"
5656
end

0 commit comments

Comments
 (0)