Fix order walkthrough for iso uniqueness#6432
Merged
adammathys merged 1 commit intosolidusio:mainfrom Apr 9, 2026
Merged
Conversation
github-actions
bot
added
the
changelog:solidus_core
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6432 +/- ##
=======================================
Coverage 89.66% 89.66%
=======================================
Files 990 990
Lines 20792 20792
=======================================
Hits 18644 18644
Misses 2148 2148 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AlistairNorman
added a commit
to SuperGoodSoft/solidus_starter_frontend
that referenced
this pull request
Apr 8, 2026
This can be dropped once we merge solidusio/solidus#6432
tvdeyen
approved these changes
Apr 8, 2026
kennyadsl
approved these changes
Apr 8, 2026
ISO is now a unique field on countries which means that creating two countries errors. Creating the country here broke tests in some extensions including solidus_starter_frontend.
AlistairNorman
force-pushed
the
country-iso-uniqueness
branch
from
75c5aeb to
faa359a
Compare
adammathys
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Alternatively I also considered adding
initialize_with { Spree::Country.find_or_initialize_by(iso:) }to the factory which seems like a broader solution to making sure iso uniqueness doesn't break tests but I findinitialize_withresults in some very unintuitive behaviour so I opted to avoid it.If anyone wants to see the test failures, they can see this run. Not all of the failures are from the iso issue but a bunch of them are.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: