fix: prevent duplicate button injection - #7
Open
Laecherlich wants to merge 1 commit into
Open
Conversation
The inject functions check for an existing button, then await an async tracking-state lookup, and only afterwards append the button. SPA DOM mutations retrigger injection while the first call is still awaiting, so several calls pass the existence check and each append their own button. Guard injection with an in-progress flag and remove any button that appeared while awaiting before appending.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Multiple start/stop buttons appear on Jira issue pages (see screenshot-reproducible on busy boards; same pattern exists for Linear and Plane).
The inject functions check whether the button exists, then
awaitthe current-time-entry lookup, and only afterwards append the button. Jira's SPA DOM mutations retrigger injection while the first call is still awaiting, so several calls pass the existence check and each append their own button — a check-then-act race whose window is as long as the API round-trip.Fix
Guard each inject function with a module-level in-progress flag, and after the await remove any button that existed or appeared meanwhile before appending. Applied consistently to jira.ts, linear.ts, and plane.ts.
Adds no new
vue-tscerrors (same error count as main).