Skip to content

Add clear signing display metadata to the IDL #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lorisleiva merged 2 commits into from
Aug 12, 2026
Merged

Add clear signing display metadata to the IDL #409

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5784ce
Add clear signing display metadata to the IDL
lorisleiva Aug 10, 2026
0338778
Drop display labels that match derived defaults
lorisleiva Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions idl.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,22 @@
"kind": "instructionRemainingAccountsNode",
"value": { "kind": "argumentValueNode", "name": "signers" },
"isOptional": true,
"isSigner": true
"isSigner": true,
"display": {
"kind": "instructionAccountDisplayNode",
"label": "Signers"
}
}
],
"name": "addMemo",
"idlName": "addMemo",
"docs": [],
"optionalAccountStrategy": "programId"
"optionalAccountStrategy": "programId",
"display": {
"kind": "instructionDisplayNode",
"intent": "Add memo",
"interpolatedIntent": "Add memo \"${data.memo}\""

@joncinque joncinque Aug 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my own information, how do the signers get shown?

@lorisleiva lorisleiva Aug 11, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They don't in the interpolatedIntent which is supposed to be this dynamic one-liner summary that doesn't contain all the information.

They should in the intent + fields version which is a static title with some dynamic fields in case the one-liner can't be safely displayed (e.g. the decimals can't be resolved and therefore the sentence can appear ambiguous). This is currently not working because the @codama/dynamic-instructions currently doesn't support it but I'm fixing this here: codama-idl/codama#1065.

@joncinque joncinque Aug 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah gotcha that makes sense, thanks!

}
}
],
"definedTypes": [],
Expand Down