refactor(basics): migrate inline dev-deps to workspace references - #659
refactor(basics): migrate inline dev-deps to workspace references#659NikkiAung wants to merge 2 commits into
Conversation
Replaces inline-pinned [dev-dependencies] versions with .workspace = true across 25 native, pinocchio, and asm Cargo.toml files under basics/. Adds four new entries to [workspace.dependencies] to cover crates that were pinned inline but not yet present in the workspace: solana-message, solana-signer, solana-rent, solana-transaction-error Excludes cross-program-invocation/native (nested workspace, not a root workspace member) and all anchor sub-workspaces. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Hi @dev-jodee, all CI checks are passing — would love to get your eyes on this when you get a chance! |
dev-jodee
left a comment
There was a problem hiding this comment.
Removed the pnpm lock and those 2 projects don't use workspace
basics/checking-accounts/native/program/Cargo.toml and basics/checking-accounts/pinocchio/program/Cargo.toml.
| @@ -0,0 +1,3737 @@ | |||
| lockfileVersion: '9.0' | |||
|
|
|||
There was a problem hiding this comment.
this file seems to be added by mistake, lets remove that
…ecking-accounts Cargo.tomls - Remove basics/counter/mpl-stack/pnpm-lock.yaml (accidentally staged) - Revert checking-accounts/native and checking-accounts/pinocchio dev-deps to inline pins — both use solana-sdk which is not in workspace, so they are excluded from the workspace dep migration Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Fixed both issues in the follow-up commit (
|
Greptile SummaryCentralizes shared Cargo dependency declarations without changing their effective constraints.
Confidence Score: 5/5The PR appears safe to merge, with the changed manifests retaining equivalent dependency constraints through valid root-workspace references. Every newly inherited dependency is declared in the root workspace, the migrated version constraints match the prior inline declarations, and no changed manifest crosses an incompatible workspace boundary. Important Files Changed
Reviews (1): Last reviewed commit: "fix(#659): remove accidental pnpm lock a..." | Re-trigger Greptile |
|
Hi @dev-jodee, both issues are addressed in |
Summary
Redo of #632 on top of current main (superseded by #656).
[dev-dependencies]versions with.workspace = trueacross 25 native, pinocchio, and asmCargo.tomlfiles underbasics/[workspace.dependencies]for crates that were inline but missing from the workspace:solana-message,solana-signer,solana-rent,solana-transaction-errorcross-program-invocation/native(nested workspace, not a root workspace member) and all anchor sub-workspacesTest plan
cargo metadata --no-depsresolves cleanly with zero errors🤖 Generated with Claude Code