Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The narrow dependency declaration matches existing native usage and the verified fix in #826, with no unresolved findings.
No open issues 🎉
What changed in this PR
This PR fixes the iOS dynamic-framework linker failure reported in #826 by explicitly declaring the system framework already used by the native clipboard implementation.
Changes:
- Adds
UniformTypeIdentifiersto the CocoaPods specification’s framework dependencies so dynamic-framework consumers can link successfully.
| File | Description |
|---|---|
| ReactNativeEnrichedHtml.podspec | Declares the UniformTypeIdentifiers framework dependency. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #826
With CocoaPods dynamic frameworks enabled, the build failed. Eg. by using an expo build and a plugin in
app.json:[ "expo-build-properties", { "ios": { "useFrameworks": "dynamic", "usePrecompiledModules": false } } ]We reference an external framework
UniformTypeIdentifiersin our code, and it worked with static frameworks, because this package was loaded by a different pod. When using the dynamic frameworks, we actually every pod need to have explicitly defined what frameworks it depends on, so they will be successfully resolved at runtime.I've setup an example app with Expo SDK 58, with dynamic frameworks enabled, and the failure was gone.
After that change, our example app builds successfully with CocoaPods and SPM.
Test Plan
Setup an Expo app, and apply this patch
Compatibility
Checklist