Repository navigation
Vulkan: keep a reshape that changes the last dim before a quantized linear - #25
Merged
msluszniak merged 1 commit intoOct 27, 2026
Conversation
…ntized linear QuantizedLinearMatch skipped any view_copy feeding the linear, assuming it is the leading-dim flatten from aten.linear's N-D decomposition. A reshape that merges attention heads ([S, H, D] -> [S, H * D]) was skipped too, so the fused et_vk.linear_q4gsw received the [S, H, D] tensor and lowering failed in the fake kernel. Skip the view only when it keeps the last dim. Backport of pytorch/executorch#24116.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of pytorch/executorch#24116.