Skip to content

A typo in OFFLINE_PUBLISH_ALLOWED_PROTOCOLS discards every offline payload #220

Closed

Description

@PromiseFru

OFFLINE_PUBLISH_ALLOWED_PROTOCOLS isn't validated. A typo such as smpt, or SMTP in capitals, passes publisher config check, and then every offline (RelaySMS Mail) payload is discarded.

We could reject entries other than https and smtp, the way DATABASE_DIALECT checks its choices, with a parametrized test.

Activity

  1. ShahadatTest commented on Nov 2, 2026

    @ShahadatTest
    Contributor

    I'd like to take this — will validate OFFLINE_PUBLISH_ALLOWED_PROTOCOLS to only https/smtp (case-normalized) with a parametrized test, matching DATABASE_DIALECT style checks.

  2. added a commit that references this issue on Nov 10, 2026
    bce8e5f
  3. PromiseFru commented on Nov 10, 2026

    @PromiseFru
    MemberAuthor

    Merged to staging in #231, and it will ship in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinggood first issueGood for newcomers

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions