Rename Config and Plugin to service-specific names#699
Open
ubaskota wants to merge 1 commit into
Open
Conversation
Alan4506
reviewed
May 21, 2026
Contributor
Alan4506
left a comment
Alan4506
left a comment
There was a problem hiding this comment.
LGTM overall. Just curious: why add the changelog entries to aws-sdk-signers, smithy-aws-core, and smithy-aws-event-stream? None of those packages' source actually changes in this PR. Do we have a better way to surface this codegen-level change?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Rename generated Config class to service-specific names derived from ServiceTrait sdkId (e.g.,
BedrockRuntimeConfig). Similarly rename Plugin to<ServiceName>Plugin. Deprecated aliases withDeprecationWarningare generated for backwards compatibility. Generic (Non-AWS SDKs) remain unchanged.Testing
make test-pyandmake test-protocols)Configis usedConfigandBedrockRuntimeConfigsuccessfully make requests and receive responsesBedrockRuntimeConfig/BedrockRuntimePluginwith deprecated aliases as expectedBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.