Skip to content

Add stellar keystore#22742

Open
ilija42 wants to merge 2 commits into
developfrom
add-stellar-keystore
Open

Add stellar keystore#22742
ilija42 wants to merge 2 commits into
developfrom
add-stellar-keystore

Conversation

@ilija42
Copy link
Copy Markdown
Contributor

@ilija42 ilija42 commented Jun 4, 2026 •
edited
Loading

@ilija42 ilija42 requested a review from a team as a code owner June 4, 2026 12:33
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2026

👋 ilija42, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@ilija42 ilija42 marked this pull request as draft June 4, 2026 12:33
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2026

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2026 •
edited
Loading

✅ No conflicts with other open PRs targeting develop

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Jun 4, 2026
View reviewed changes
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 67a5097897

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread core/services/keystore/stellar.go
Comment thread core/services/keystore/master.go
@ilija42 ilija42 mentioned this pull request Jun 4, 2026
Merged
@trunk-io
Copy link
Copy Markdown

trunk-io Bot commented Jun 4, 2026 •
edited
Loading

Static Badge   Static Badge   Static Badge   Static Badge

View Full Report ↗︎ ⋅ Docs

@ilija42 ilija42 force-pushed the add-stellar-keystore branch from 8106264 to 155fc12 Compare June 5, 2026 14:07
@ilija42 ilija42 force-pushed the add-stellar-keystore branch from 155fc12 to 6f099e4 Compare June 5, 2026 14:10
@ilija42 ilija42 marked this pull request as ready for review June 5, 2026 14:10
@ilija42 ilija42 requested review from a team as code owners June 5, 2026 14:10
@cl-sonarqube-production
Copy link
Copy Markdown

cl-sonarqube-production Bot commented Jun 5, 2026

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

@jmank88 jmank88 jmank88 approved these changes

@Unheilbar Unheilbar Unheilbar approved these changes

@pavel-raykov pavel-raykov pavel-raykov approved these changes

@kalverra kalverra Awaiting requested review from kalverra

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ilija42 @jmank88 @Unheilbar @pavel-raykov