Move binary_url back into the hash; deprecate the outside-envelope field#387
Open
nadahalli wants to merge 4 commits into
Open
Move binary_url back into the hash; deprecate the outside-envelope field#387nadahalli wants to merge 4 commits into
nadahalli wants to merge 4 commits into
Conversation
…in-hash binary_url Pivot away from the per-node pre-signed URL design. binary_url returns to WorkflowExecution (PublicData, covered by ComputeRequest.Hash()) as a stable canonical locator; the enclave authenticates to the storage service out of band via a fetch sidecar, so per-node URLs are no longer needed. - WorkflowExecution.binary_url: restored as the canonical field. - ConfidentialWorkflowRequest.binary_url: deprecated (kept for back-compat). - vault_don_secrets: deprecated (enclave fetches secrets dynamically at runtime).
capabilities-development does not deprecate vault_don_secrets, so neither should this PR. Revert that field and its message comment to match the branch; the only net change is the binary_url move back into the hash.
|
product-security-plaid-production
Bot
requested review from
ChrisAmora and
DylanTinianov
|
The latest Buf updates on your PR. Results from workflow Regenerate Protobuf Files / buf (pull_request).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pivots the confidential-workflows binary fetch away from per-node pre-signed URLs.
binary_urlreturns toWorkflowExecution(insidePublicData, covered byComputeRequest.Hash()) as a stable, node-agnostic canonical locator. Theenclave will authenticate to the storage service out of band via a fetch
sidecar, so per-node URLs are no longer needed and the value can live inside
the hash envelope again.
WorkflowExecution.binary_url: restored as the canonical field (wascomment-deprecated by Restructure ConfidentialWorkflow proto additively (no Go API break) #376).
ConfidentialWorkflowRequest.binary_url: deprecated ([deprecated = true]),kept for back-compat, no longer populated.
Proto-only, additive (no field removed or renumbered), so no Go API break.
Downstream: chainlink-common regen + bump, then chainlink/core and
confidential-compute. PRs #22590 and CC #343 are being reworked on top of this.