Remind user that cre_settings changes might involve re-proposing job-specs#2129
Remind user that cre_settings changes might involve re-proposing job-specs#2129yashnevatia wants to merge 6 commits into
Conversation
|
👋 yashnevatia, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
CRE settings touchedThis PR changes files under If the settings schema changed (new/renamed/removed fields or different defaults), before merge:
Test-only changes under |
📊 API Diff Results
|
There was a problem hiding this comment.
Pull request overview
This PR adjusts CRE default settings for Aptos chain writes and adds an automated GitHub Actions reminder to flag PRs that touch CRE settings schema files.
Changes:
- Increase the default Aptos
ChainWrite.ReportSizeLimitfrom5kbto6kb. - Add a PR-commenting workflow that triggers when files under
pkg/settings/cresettings/**change to remind authors to check downstream deployment overrides.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
pkg/settings/cresettings/settings.go |
Updates the Aptos chain write report size default in the CRE settings schema. |
.github/workflows/cre-settings-schema-reminder.yml |
Adds a PR reminder workflow to highlight potential schema/default-impacting changes under pkg/settings/cresettings/**. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| Aptos: aptosChainWrite{ | ||
| ReportSizeLimit: Size(5 * config.KByte), | ||
| ReportSizeLimit: Size(6 * config.KByte), | ||
| GasLimit: PerChainSelector(Uint64(2_000_000), map[string]uint64{}), |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CRE settings touchedThis PR changes files under
Test-only changes under |
…ontractkit/chainlink-common into ci-action-settings-override
CRE settings touchedThis PR changes files under
|
CRE settings field deprecatedThis PR adds When making the corresponding capabilities change (where this settings field is consumed), keep the change backward compatible — the new code should still respect the old field. Rollout:
|
1 similar comment
CRE settings field deprecatedThis PR adds When making the corresponding capabilities change (where this settings field is consumed), keep the change backward compatible — the new code should still respect the old field. Rollout:
|
Co-authored-by: Jordan Krage <jmank88@gmail.com>
Requires
Supports