Repository navigation
fix(cli): estimate gas limit during EVM execute and floor at message's execGasLimit - #1153
Merged
Merged
Conversation
rodrigombsoares
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EVM transaction simulation during EVM
executedoes not behave as expected:It defaults to the lowest possible gas limit that leads to the tx not reverting. The way the EVM contracts are designed, if a message is in state
UNTOUCHED, a too-low gas limit will cause it to be put intoFAILUREstate with the transaction not reverting, which causes the transaction simulation to pick a too-low gas limit.This means execution currently has to always be run twice, with the transaction moving
UNTOUCHED->FAILURE->SUCCESS.Updating the CLI to properly estimate the gas limit + floor it at the message's
executionGasLimit, which should cause it to succeed on first try.