Repository navigation
Grpc opts - #845
Closed
cedric-cordenier wants to merge 4 commits into
Closed
Grpc opts#845cedric-cordenier wants to merge 4 commits into
cedric-cordenier wants to merge 4 commits into
Conversation
Mirror loop.Server: build the gRPC options with loop.GRPCOptsConfig after telemetry has started and thread them into StartCapabilities. Embedded starts without a run get their own options on a private registry.
The registry proxy, the remote transport's callbacks and the settings client now dial with loop's interceptors (otelgrpc, CRE context, grpcprom), as a LOOP's clients do, rather than a bare insecure client.
The remote transport now makes its servers with GRPCOpts.NewServer. Before this change, it used a plain grpc.NewServer, which had no interceptors. Now calls from the node use the loop interceptors, as LOOP servers do.
The LOOP host sets the limit with loop.EnvConfig.AsCmdEnv. The test makes sure that GRPCConfig.ServerMaxRecvMsgSize contains the same limit.
cedric-cordenier
force-pushed
the
grpc-opts
branch
from
October 23, 2026 12:37
39306e9 to
9186e33
Compare
cedric-cordenier
marked this pull request as ready for review
October 23, 2026 12:37
product-security-plaid-production
Bot
requested review from
DylanTinianov and
ilija42
October 23, 2026 12:37
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.