Repository navigation
stellar: bill the transaction named in the WriteReport reply - #841
Merged
Merged
Conversation
…other chains do After a submit, metering now comes from the reply's on-chain fee instead of the local submit response, so a node whose duplicate failed bills the canonical tx like every other node, and a missing fee yields no record instead of 0. Errors return empty metadata and the wrapper returns nil: the generated capability server drops the output on error, so metering next to an error never reached the DON. Removes meteringFromSubmitResponse.
Wire the shared gasmeter into the Stellar LOOP like EVM and Solana: read the host [Metering] config, build the meter with the chain selector and capability DON id, and emit one usage record per write from meteringFromReply so the record names the same canonical transaction and fee the DON bills. Bumps chain_capabilities/common and chainlink-common to the versions that carry gasmeter.
Reverts 014c0d7. The cre:workflow:gas record needs [Metering] on the chain-capabilities DON configs first and will go in its own PR. This PR stays limited to billing the transaction named in the reply.
ilija42
marked this pull request as ready for review
October 22, 2026 14:34
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
product-security-plaid-production
Bot
requested review from
DylanTinianov,
mchain0 and
silaslenihan
October 22, 2026 14:34
|
Unheilbar
approved these changes
Oct 22, 2026
amit-momin
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stellar's WriteReport billed the local submit fee after a submit, while nodes that returned early billed the canonical tx. On a failed duplicate the reply and the metering described two different transactions, and a missing submit fee billed 0.
meteringFromSubmitResponse.