Skip to content

feat: add a pr-body input to oci-image-bump - #1713

Merged
tvc-jeffwelling merged 2 commits into
mainfrom
feat/IP-4105-oci-image-bump-body
Oct 22, 2026
Merged

tvc-jeffwelling merged 2 commits into
mainfrom
feat/IP-4105-oci-image-bump-body

Conversation

@tvc-jeffwelling

@tvc-jeffwelling tvc-jeffwelling commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Adds an optional pr-body input to oci-image-bump, passed to create-pull-request as body-path when set. Callers that do not set it keep today's default body, because the action only passes body-path when the input is non-empty.

Why: the auto/deploy PRs this action creates must carry the change-management sections that IP-4105 enforces. The generated PRs carry the create-pull-request default body, which has none of the sections, so they would fail the new check once it becomes required. Callers cannot set the body today, because the action owns the create-pull-request step. This PR adds the input that lets a caller supply one.

How this PR satisfies it: it is the plumbing only. The companion caller change fills the three sections (run link, 30-minute criteria, revert) and passes them as pr-body.

Ticket: https://smartcontract-it.atlassian.net/browse/IP-4105

Passes the body to create-pull-request as body-path when set, so an empty input keeps the default body. The auto/deploy PRs this action creates need to carry the change-management sections enforced by IP-4105.
@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

🦋 Changeset is good to go

Latest commit: 8d58b91

We got this.

Not sure what this means? Click here to learn what changesets are.

@tvc-jeffwelling
tvc-jeffwelling marked this pull request as ready for review October 22, 2026 15:22
@tvc-jeffwelling
tvc-jeffwelling requested a review from a team as a code owner October 22, 2026 15:22
@chainchad

Copy link
Copy Markdown
Collaborator

Would also recommend looking at the new MR. PRIB setup as that might need to be updated too since it creates automated PRs for image bumps.

Comment thread actions/oci-image-bump/action.yml
@tvc-jeffwelling

tvc-jeffwelling commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor Author

Good catch. Checked: MR. PRIB PRs are opened by the gcli set-tag path, and nothing in that chain takes a body today (set-tag has a title option only). The generated body is the set-tag table, so those PRs fail the check once the check is required in a repo that receives them.

Where this matters, and where it does not: the check rolls out to private repos first, and none of those receives MR. PRIB PRs. The repos that receive MR. PRIB PRs today are internal deploy repos, and none of them has the check. So nothing breaks today. It becomes a problem the moment a MR. PRIB subscriber repo turns the check on, since the auto PRs would fail until they carry the sections.

Tracked as IP-4122: https://smartcontract-it.atlassian.net/browse/IP-4122

@tvc-jeffwelling
tvc-jeffwelling merged commit d98333a into main Oct 22, 2026
20 checks passed
@tvc-jeffwelling
tvc-jeffwelling deleted the feat/IP-4105-oci-image-bump-body branch October 22, 2026 18:11
@gati-app gati-app Bot mentioned this pull request Oct 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants