Repository navigation
feat: add a pr-body input to oci-image-bump - #1713
Conversation
Passes the body to create-pull-request as body-path when set, so an empty input keeps the default body. The auto/deploy PRs this action creates need to carry the change-management sections enforced by IP-4105.
🦋 Changeset is good to goLatest commit: 8d58b91 We got this. Not sure what this means? Click here to learn what changesets are. |
|
Would also recommend looking at the new MR. PRIB setup as that might need to be updated too since it creates automated PRs for image bumps. |
|
Good catch. Checked: MR. PRIB PRs are opened by the gcli set-tag path, and nothing in that chain takes a body today (set-tag has a title option only). The generated body is the set-tag table, so those PRs fail the check once the check is required in a repo that receives them. Where this matters, and where it does not: the check rolls out to private repos first, and none of those receives MR. PRIB PRs. The repos that receive MR. PRIB PRs today are internal deploy repos, and none of them has the check. So nothing breaks today. It becomes a problem the moment a MR. PRIB subscriber repo turns the check on, since the auto PRs would fail until they carry the sections. Tracked as IP-4122: https://smartcontract-it.atlassian.net/browse/IP-4122 |
Adds an optional
pr-bodyinput tooci-image-bump, passed to create-pull-request asbody-pathwhen set. Callers that do not set it keep today's default body, because the action only passesbody-pathwhen the input is non-empty.Why: the auto/deploy PRs this action creates must carry the change-management sections that IP-4105 enforces. The generated PRs carry the create-pull-request default body, which has none of the sections, so they would fail the new check once it becomes required. Callers cannot set the body today, because the action owns the create-pull-request step. This PR adds the input that lets a caller supply one.
How this PR satisfies it: it is the plumbing only. The companion caller change fills the three sections (run link, 30-minute criteria, revert) and passes them as
pr-body.Ticket: https://smartcontract-it.atlassian.net/browse/IP-4105