refactor(adapters): migrate MQTT, Web and UI to commands and snapshots by stritti · Pull Request #218 · smart-swimmingpool/pool-controller

stritti · 2026-10-04T16:13:58Z

Draft architecture migration

Incrementally migrates adapter boundaries to the Core-1 typed-command / immutable-snapshot architecture while preserving existing MQTT/Web contracts.

Target

inbound runtime mutations become typed ControllerCommand values
one Core-1 application handler owns controller-state mutation
outbound adapters consume SystemSnapshot value copies
provisioning/authentication secrets and calibration stay behind dedicated service boundaries
legacy hand-over queues are removed only after equivalent typed-path coverage exists

Dependencies integrated in this branch

refactor(architecture): add typed controller command and snapshot contracts #214 controller architecture contracts
refactor(domain): store operation mode as typed enum #215 typed operation mode
refactor(application): add bounded typed controller command queue #216 bounded typed command queue
refactor(application): add coherent controller snapshot store #217 snapshot store

Implemented in this draft

instance-based ControllerCommandHandler composed in main.cpp
complete typed runtime-command contract with validation and persistence boundaries
MQTT callback reduced to fixed-size byte hand-over; no controller mutation on AsyncTCP
MQTT runtime topics translated to ControllerCommand on the Core-1 loop
independent timer-start and timer-end updates without stale-state reconstruction
manual pump policy centralized in the application handler
sensor-mapping updates routed through the typed handler
non-runtime MQTT operations remain delegated to their existing specialized services
native regression coverage for dispatch, bounded processing, timer updates, manual-pump guard and sensor mapping
OpenSpec task/design state kept in sync

Verified so far

Native Tests: green
PlatformIO CI: green on the current functional slice
cppcheck/cpplint and repository linters: green; final clang-format cleanup is being verified on the latest head
no open inline review threads at the last review check

Still draft

route Web runtime mutations through the same handler
route local UI mutations through the same handler
publish/populate SystemSnapshot from the Core-1 owner
migrate MQTT/Web/OLED/TFT read paths to snapshots
remove remaining direct mutable Nodes.hpp access from migrated adapters
remove the legacy MqttCommandQueue after typed hand-over equivalence is complete

The PR intentionally remains a draft until these migration steps and their contract tests are complete.

github-actions · 2026-10-04T16:14:38Z

✅⚠️MegaLinter analysis: Success with warnings

Descriptor	Linter	Files	Errors	Elapsed time
✅ ACTION	actionlint	8	0	0.61s
✅ BASH	bash-exec	2	0	0.56s
✅ BASH	shellcheck	2	0	0.55s
✅ BASH	shfmt	2	0	0.01s
✅ C	clang-format	1	0	0.04s
✅ C	cppcheck	1	0	0.02s
✅ C	cpplint	1	0	0.28s
✅ CPP	clang-format	104	0	0.66s
✅ CPP	cppcheck	104	0	5.73s
✅ CPP	cpplint	104	0	7.19s
✅ EDITORCONFIG	editorconfig-checker	293	0	0.6s
✅ JSON	jsonlint	6	0	0.11s
✅ JSON	v8r	6	0	4.63s
⚠️ MARKDOWN	markdownlint	110	4	4.03s
✅ YAML	yamllint	27	0	0.68s

Detailed Issues

⚠️ MARKDOWN / markdownlint - 4 errors

.opencode/skills/web-ui/SKILL.md:34 error MD028/no-blanks-blockquote Blank line inside blockquote
docs/superpowers/plans/2026-08-10-olimex-c6-local-ui-implementation.md:106:401 error MD013/line-length Line length [Expected: 400; Actual: 452]
docs/superpowers/plans/2026-08-16-norvi-button-calibration.md:7:401 error MD013/line-length Line length [Expected: 400; Actual: 412]
openspec/changes/controller-architecture-contracts/design.md:171:401 error MD013/line-length Line length [Expected: 400; Actual: 448]

Notices

⚠️ Your configuration references items that have been removed from MegaLinter and are ignored: MAKEFILE, MAKEFILE_CHECKMAKE, MARKDOWN_MARKDOWN_LINK_CHECK. See Removed linters to find their replacements.

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

Documentation: Custom Flavors
Command: npx mega-linter-runner@10.1.0 --custom-flavor-setup --custom-flavor-linters ACTION_ACTIONLINT,BASH_EXEC,BASH_SHELLCHECK,BASH_SHFMT,C_CPPCHECK,C_CPPLINT,C_CLANG_FORMAT,CPP_CPPCHECK,CPP_CPPLINT,CPP_CLANG_FORMAT,EDITORCONFIG_EDITORCONFIG_CHECKER,JSON_JSONLINT,JSON_V8R,MARKDOWN_MARKDOWNLINT,YAML_YAMLLINT

Show us your support by starring ⭐ the repository

github-actions · 2026-10-04T16:15:11Z