Skip to content

refactor(multicore): remove obsolete worker-task paths - #213

Closed
stritti wants to merge 5 commits into
feat/multicore-task-architecturefrom
refactor/multicore-boundary-cleanup
Closed

stritti wants to merge 5 commits into
feat/multicore-task-architecturefrom
refactor/multicore-boundary-cleanup

Conversation

@stritti

@stritti stritti commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

Summary

Tightens the final ownership model from #170 and removes the abandoned parallel paths that would reintroduce cross-core access to mutable controller state.

Changes

  • remove obsolete PublishTask.*
  • remove obsolete DisplayTask.*
  • align PoolController.cpp comments with the actual scheduler behavior
  • explicitly document that NORVI UI rendering stays on Core 1
  • explicitly document that telemetry is drained on the Core-1 loop task

Architectural intent

After this PR the multicore model has one worker responsibility only:

  • Core 0: sensor/OneWire acquisition
  • Core 1: mutable controller state, rules, relays, MQTT, Web, OTA and UI

This keeps #170 focused on the minimum concurrency boundary and avoids leaving dead alternative implementations in the tree.

Base

Stacked on feat/multicore-task-architecture / #170.

@github-actions

github-actions Bot commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

✅⚠️MegaLinter analysis: Success with warnings

Descriptor Linter Files Fixed Errors Max errors Warnings Elapsed time
✅ ACTION actionlint 8 0 0 0.78s
✅ BASH bash-exec 2 0 0 0.67s
✅ BASH shellcheck 2 0 0 0.68s
✅ BASH shfmt 2 0 0 0.01s
✅ C clang-format 1 0 0 0.04s
✅ C cppcheck 1 0 0 0.03s
✅ C cpplint 1 0 0 0.32s
✅ CPP clang-format 102 0 0 0.81s
✅ CPP cppcheck 102 0 0 6.48s
✅ CPP cpplint 102 0 0 7.91s
✅ EDITORCONFIG editorconfig-checker 286 0 0 0.73s
✅ JSON jsonlint 6 0 0 0.13s
✅ JSON v8r 6 0 0 4.01s
⚠️ MARKDOWN markdownlint 107 3 0 4.22s
✅ YAML yamllint 25 0 0 0.84s

Detailed Issues

⚠️ MARKDOWN / markdownlint - 3 errors
.opencode/skills/web-ui/SKILL.md:34 error MD028/no-blanks-blockquote Blank line inside blockquote
docs/superpowers/plans/2026-08-10-olimex-c6-local-ui-implementation.md:106:401 error MD013/line-length Line length [Expected: 400; Actual: 452]
docs/superpowers/plans/2026-08-16-norvi-button-calibration.md:7:401 error MD013/line-length Line length [Expected: 400; Actual: 412]

Notices

⚠️ Your configuration references items that have been removed from MegaLinter and are ignored: MAKEFILE, MAKEFILE_CHECKMAKE, MARKDOWN_MARKDOWN_LINK_CHECK. See Removed linters to find their replacements.

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@10.1.0 --custom-flavor-setup --custom-flavor-linters ACTION_ACTIONLINT,BASH_EXEC,BASH_SHELLCHECK,BASH_SHFMT,C_CPPCHECK,C_CPPLINT,C_CLANG_FORMAT,CPP_CPPCHECK,CPP_CPPLINT,CPP_CLANG_FORMAT,EDITORCONFIG_EDITORCONFIG_CHECKER,JSON_JSONLINT,JSON_V8R,MARKDOWN_MARKDOWNLINT,YAML_YAMLLINT

MegaLinter is provided by OX Security
Show us your support by starring ⭐ the repository

@github-actions

github-actions Bot commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

Native Test Coverage

Metric Value
Line Coverage 61.8%
Branch Coverage 71.8%
Lines Hit/Total 525/850
Branches Hit/Total 216/301

Report from native unit tests (ASan + gcov).

@stritti stritti mentioned this pull request Oct 4, 2026
5 tasks

stritti commented Oct 4, 2026

Copy link
Copy Markdown
Contributor Author

Der aktuelle Head von #170 enthält diese Bereinigung inzwischen selbst: PublishTask/DisplayTask und TaskStartupPolicy sind entfernt, CoreScheduler besitzt nur noch den SensorTask, Telemetrie und UI bleiben auf Core 1 und die Multicore-Dokumentation ist entsprechend aktualisiert. Damit ist #213 fachlich vollständig durch #170 superseded. Eine Synchronisierung würde dieselben Änderungen nur erneut gegen den bereits bereinigten Base-Branch anwenden und Konflikte erzeugen. Ich schließe #213 daher als redundant; die relevante Verifikation bleibt auf #170.

@stritti stritti closed this Oct 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant