Skip to content

docs(block-kit): refine design guidance - #168

Closed
wgminer wants to merge 1 commit into
slackapi:block-kit-design-referencesfrom
wgminer:block-kit-hig-pass
Closed

wgminer wants to merge 1 commit into
slackapi:block-kit-design-referencesfrom
wgminer:block-kit-hig-pass

Conversation

@wgminer

@wgminer wgminer commented Oct 5, 2026

Copy link
Copy Markdown

Summary

  • incorporate focused data visualization guidance into data-display-design.md
  • make the new design references more consistent and direct, with implementation details separated from design guidance
  • add an Approval Set pattern and align the Approval Message pattern with the guidance

This is a focused follow-up to #167. Merging it adds the commit to the block-kit-design-references branch and therefore updates #167.

Validation

  • make lint
  • make test-unit (21 passed)

Incorporate focused data visualization guidance and make the design references read consistently: lead with direct recommendations, separate implementation details, use consistent terminology, and add a reusable approval-set pattern.

Co-Authored-By: Codex <svc-devxp-Codex@slack-corp.com>
@wgminer
wgminer requested a review from a team as a code owner October 5, 2026 19:49
@changeset-bot

changeset-bot Bot commented Oct 5, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 95354ec

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
slack Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@salesforce-cla

salesforce-cla Bot commented Oct 5, 2026

Copy link
Copy Markdown

Thanks for the contribution! Unfortunately we can't verify the commit author(s): Will Miner <w***@s***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce Inc. Contributor License Agreement and this Pull Request will be revalidated.

@wgminer

wgminer commented Oct 5, 2026

Copy link
Copy Markdown
Author

Closing this version so I can replace the blanket use of ‘people’ with contextually natural product language and reopen a clean review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant