Skip to content

refactor: remove unused crop resize image from file function #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mwbrooks merged 1 commit into from
Oct 9, 2026
Merged

refactor: remove unused crop resize image from file function #691

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions internal/image/image.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,16 +30,6 @@ import (
"github.com/spf13/afero"
)

func CropResizeImageRatioFromFile(fs afero.Fs, filepath string, width uint, widthRatio, heightRatio int) (image.Image, error) {
reader, err := fs.Open(filepath)
if err != nil {
return nil, err
}
defer reader.Close()

return CropResizeImageRatio(reader, width, widthRatio, heightRatio)
}

func CropResizeImageRatioFromFileToBytes(fs afero.Fs, filepath string, width uint, widthRatio, heightRatio int) ([]byte, error) {
reader, err := fs.Open(filepath)
if err != nil {
Expand Down
17 changes: 0 additions & 17 deletions internal/image/image_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,23 +97,6 @@ func Test_CropResizeImageRatioToBytes(t *testing.T) {
assert.NotEmpty(t, result)
}

func Test_CropResizeImageRatioFromFile(t *testing.T) {
pngData := createTestPNG(t, 200, 100)
fs := slackdeps.NewFsMock()
err := afero.WriteFile(fs, "/test.png", pngData, 0644)
require.NoError(t, err)

result, err := CropResizeImageRatioFromFile(fs, "/test.png", 100, 1, 1)
require.NoError(t, err)
assert.NotNil(t, result)
}

func Test_CropResizeImageRatioFromFile_FileNotFound(t *testing.T) {
fs := slackdeps.NewFsMock()
_, err := CropResizeImageRatioFromFile(fs, "/nonexistent.png", 100, 1, 1)
assert.Error(t, err)
}

func Test_CropResizeImageRatioFromFileToBytes(t *testing.T) {
pngData := createTestPNG(t, 200, 100)
fs := slackdeps.NewFsMock()
Expand Down
Loading