Repository navigation
feat: support the user_connections manifest feature - #688
Draft
WilliamBergamin wants to merge 1 commit into
Draft
WilliamBergamin wants to merge 1 commit into
WilliamBergamin wants to merge 1 commit into
Conversation
Add features.user_connections (is_enabled, auth_hosts) to the app manifest types so the field round-trips through run, deploy, and manifest sync instead of being dropped when the manifest is decoded. Both fields are required by the manifest schema, so neither is omitted when empty: a disabled feature keeps its auth hosts. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #688 +/- ##
=======================================
Coverage 78.23% 78.23%
=======================================
Files 239 239
Lines 18149 18149
=======================================
Hits 14199 14199
Misses 3950 3950 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
The
features.user_connectionsapp manifest property (is_enabled,auth_hosts) is now supported, so it is kept byrun,deploy, andmanifest sync.Summary
The CLI decodes
manifest.json(or theget-manifesthook output) into typed manifest structs, so any property it does not model is silently dropped before the manifest is sent to Slack. This addsfeatures.user_connectionstoAppFeaturesso apps that opt into the standardized user connection flow keep that setting.Both fields are required by the manifest schema, so neither uses
omitempty: a disabled feature ("is_enabled": false) keeps itsauth_hosts, which is how the feature is meant to be turned off.Preview
slack manifest info --source localwithfeatures.user_connectionsinmanifest.json:Before (
main): the property is strippedAfter (this branch): the property round-trips
Testing
Test_AppManifest_AppFeaturesfor enabled and explicitly disableduser_connections.Test_AppManifest_AppFeatures_UserConnectionsdecodes manifest JSON, asserts the typed value, and checks it re-marshals unchanged (undefined, enabled, disabled with hosts).make testpasses (lint: 0 issues).mainand this branch, ranslack manifest info --source localon a sample project with the property (output above).Notes
user_connectionsto slackapi/manifest-schema so editors stop flagging it.Requirements
🤖 Generated with Claude Code