Repository navigation
feat: add the user_connections feature to the app manifest types - #2775
Draft
WilliamBergamin wants to merge 1 commit into
Draft
WilliamBergamin wants to merge 1 commit into
WilliamBergamin wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2775 +/- ##
==========================================
+ Coverage 89.38% 89.46% +0.07%
==========================================
Files 65 65
Lines 10525 10525
Branches 478 478
==========================================
+ Hits 9408 9416 +8
+ Misses 1086 1078 -8
Partials 31 31
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds the
features.user_connectionsapp manifest property (is_enabled,auth_hosts) to the manifest types, matching slackapi/slack-cli#688, so apps that opt into the standardized user connection flow can pass it toapps.manifest.create,updateandvalidatewithout a type error.Both fields are required, like Slack's manifest API, which rejects a
user_connectionsobject missing either one. Host format and item limits (1 to 25 hosts, no scheme) are validated by Slack.Testing
tsdcases in theapps.manifest.createsection oftest/types/methods/apps.test-d.ts: missingis_enabledorauth_hostsis an error; enabled, and disabled with hosts, are assignable. (npm run test:types --workspace=packages/web-api; the only failures are the existingfiles.uploadandrtm.startcases, also failing onmain.)npm run lintandnpm test --workspace=packages/web-apipass.Requirements
🤖 Generated with Claude Code