Repository navigation
chore: replace flake8 and black with ruff - #89
Merged
Merged
Conversation
Ports the bolt-python (#1566, #1567) and python-slack-sdk (#1954, #1959) migration in one change, since the only Python here is the tests/ folder. ruff check and ruff format replace flake8 and black; lint.sh now also gates on ruff format --check. Existing sources need no changes. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
WilliamBergamin
commented
Sep 30, 2026
test.sh and install_all_and_run_tests.sh now delegate formatting to scripts/format.sh instead of inlining ruff/prettier, so the formatting steps live in one place. Also drops an unneeded pyproject.toml comment. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces flake8 (lint) and black (format) with ruff, which does both. This mirrors slackapi/bolt-python#1566 + #1567 and slackapi/python-slack-sdk#1954 + #1959, folded into one PR since the only Python here is
tests/.pyproject.toml:flake8+blackdeps becomeruff==0.16.4;[tool.black]becomes the same[tool.ruff]config as bolt/sdk (E,W,F,Dwith google convention,D100-D107ignored), keepingline-length = 100..flake8removed.scripts/lint.shrunsruff check+ruff format --check, so CI now gates on formatting (black was never checked in CI).format.sh,test.sh,install_all_and_run_tests.shuse ruff.AGENTS.md, maintainers guide and the CI step name updated.No Python source changes were needed: the existing tests already pass every rule.
Testing
./scripts/lint.sh→All checks passed!/4 files already formatted/ Prettier clean./scripts/format.shtwice → no diff./scripts/install_all_and_run_tests.sh→6 passedCategory
manifest.schema.jsonedit/schemaand/or its core componentsRequirements
./scripts/install_all_and_run_tests.shafter making the changes.🤖 Generated with Claude Code