122. Best Time to Buy and Sell Stock II#43
Open
skypenguins wants to merge 1 commit into
Open
Conversation
colorbox
reviewed
Jul 6, 2026
| # 谷を探す | ||
| while i < n - 1 and prices[i] >= prices[i + 1]: | ||
| i += 1 | ||
| valley = prices[i] |
There was a problem hiding this comment.
好みの問題かもしれませんが、peakに対するvalleyに違和感を感じました。
peakはその時に最高値という意味がわかりやすいのですが、valleyに対してはpeakほどわかりやすくなかったです。
個人的にはtop-bottomもしくはtop_price - bottom_priceにすると思いました。
軽く調べたところ、金融文脈だと peak-troughという語彙があるそうです。
nodchip
reviewed
Jul 6, 2026
| if profit > 0: | ||
| total_profit += profit | ||
| cheapest_price = float("inf") | ||
| profit = 0 |
There was a problem hiding this comment.
18 行目と 26 行目の profit = 0 は、 22 行目の代入文で上書きされるため、不要だと思いました。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
122. Best Time to Buy and Sell Stock II
次回予告: 153. Find Minimum in Rotated Sorted Array