fix: frame invariants (sortBy, selectRows, range, rename) - #5
Open
skymanbp wants to merge 1 commit into
Open
Conversation
- sortBy on a wrongly-typed column silently returned the frame unsorted; it now throws TypeMismatchException like filter does. - selectRows bounds-checks indices before the unsafe gather. - range clips both bounds instead of crashing on a past-the-end slice. - rename onto an existing column name errors instead of orphaning it.
skymanbp
force-pushed
the
fix/invariants
branch
from
August 19, 2026 06:49
851f17c to
e827501
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fork validation PR. 8 files, +5 HUnit cases (1102 total green), +4 prop groups.