SK-2839: pin dependency versions and harden CI against supply chain attacks#220
Open
saileshwar-skyflow wants to merge 2 commits into
Open
SK-2839: pin dependency versions and harden CI against supply chain attacks#220saileshwar-skyflow wants to merge 2 commits into
saileshwar-skyflow wants to merge 2 commits into
Conversation
…gainst supply chain attacks - Pin all dependencies/devDependencies in package.json to exact locked versions from package-lock.json (remove ^ and ~ prefixes); peerDependencies unchanged - Add --ignore-scripts to every npm install call across all 5 CI workflows - Create .npmrc with ignore-scripts=true at repo root and samples/SkyflowElements/ Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
|
Semgrep findings: No issues found, Good to merge. |
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
|
Semgrep findings: No issues found, Good to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
package.jsonto exact versions resolved inpackage-lock.json(removes all^/~prefixes fromdependenciesanddevDependencies;peerDependenciesunchanged)--ignore-scriptsto everynpm installcall across all 5 CI workflows (CI.yml,main.yml,release.yml,internal-release.yml,beta-release.yml) — 7 call sites total.npmrcwithignore-scripts=trueat repo root andsamples/SkyflowElements/Motivation
Hardens the repo against the Mini Shai-Hulud npm supply chain attack campaign, which exploits floating version ranges and lifecycle scripts (
postinstall,prepare, etc.) to execute malicious code duringnpm install. Pre-flight audit confirmed zero legitimate install scripts in this repo's dependency tree.