SK-2839: Harden against supply chain attacks (pin versions + ignore-scripts)#697
Merged
saileshwar-skyflow merged 2 commits intoJun 5, 2026
Conversation
…gainst supply chain attacks - Remove all ^ and ~ version ranges from package.json; replace with exact versions resolved from package-lock.json (42 packages updated) - Add --ignore-scripts flag to npm ci / npm install in all three CI workflow files - Create .npmrc with ignore-scripts=true as a project-level default for local installs Audit confirmed zero packages in the 1,067-package dependency tree have postinstall/install lifecycle scripts, so --ignore-scripts is unconditionally safe. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…n npm 6.x In npm 6 (bundled with Node 14, which CI uses), setting ignore-scripts=true in .npmrc suppresses ALL package.json scripts including explicit `npm run` invocations. This caused webpack to silently skip execution, leaving dist/v1 uncreated and breaking the Deploy to S3 step in the release workflow. The --ignore-scripts flag is already applied directly on each npm install / npm ci command in the CI workflows, which is the correctly-scoped approach. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
|
Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging. |
saileshwar-skyflow
changed the title
skyflow-bharti
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
^/~range specifier frompackage.jsonand replaces them with the exact versions currently resolved inpackage-lock.json(42 packages updated). Prevents a compromised minor/patch release from being silently pulled on the next install.--ignore-scriptsto all CI install commands (npm ciinmain.ymlandpr.yml,npm installincommon-release.yml) and create.npmrcwithignore-scripts=trueas a project-level default for local installs. Blocks maliciouspostinstallhooks from executing.Install-script safety audit
All 1,067 packages in the dependency tree were scanned for
postinstall,preinstall, andinstalllifecycle scripts. Zero packages have such hooks — no native binaries, no compiled modules, no build-time setup.--ignore-scriptsis unconditionally safe for this repo.Files changed
package.json.npmrcignore-scripts=true.github/workflows/main.ymlnpm ci→npm ci --ignore-scripts.github/workflows/pr.ymlnpm ci→npm ci --ignore-scripts.github/workflows/common-release.ymlnpm install→npm install --ignore-scriptsNo source files, no logic changes, no version upgrades.