Skip to content

fix: 🐞 include serviceId and routingKey in useServiceData - #612

Open
pierpman wants to merge 1 commit into
skupperproject:mainfrom
pierpman:feat/mkl
Open

pierpman wants to merge 1 commit into
skupperproject:mainfrom
pierpman:feat/mkl

Conversation

@pierpman

Copy link
Copy Markdown
Contributor

Description

Fix query-cache key collision in useServiceData that caused incorrect tab enabled/disabled
states when navigating between two different Services in the same browser session.

How to test

Automated

yarn tsc --noEmit          # must be clean
yarn vitest run            # 322 tests across 79 files — all must pass

Manual (requires mock server)

USE_MOCK_SERVER=true MOCK_RESPONSE_DELAY=1500 yarn start
  1. Open the Services list and navigate to productcatalogservice.
    Confirm the Open connections tab becomes enabled (it has 2 active connections).
  2. Without reloading, navigate to emailservice.
    Confirm the Open connections tab is disabled from the first render — it must not
    briefly show as enabled while emailservice's request is loading.
  3. Navigate back to productcatalogservice.
    Confirm Open connections is enabled from the first render (served from cache).

@pierpman pierpman changed the title fix: :ladybug: include serviceId and routingKey in useServiceDat… fix: 🐞 include serviceId and routingKey in useServiceDat… Oct 23, 2026

@c-kruse c-kruse left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find

@pierpman pierpman changed the title fix: 🐞 include serviceId and routingKey in useServiceDat… fix: 🐞 include serviceId and routingKey in useServiceData Oct 27, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Service detail tabs show incorrect enabled state when navigating between Services

2 participants