Skip to content

fix: 🐞 "Data links" tab in Process details using mock data - #609

Merged
pierpman merged 3 commits into
skupperproject:mainfrom
pierpman:fix/608
Oct 5, 2026
Merged

pierpman merged 3 commits into
skupperproject:mainfrom
pierpman:fix/608

Conversation

@pierpman

@pierpman pierpman commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Description

Fix the getProcessPairs mock handler in mocks/server.API.ts to prevent the "Data links"
tab from being permanently disabled on Process detail pages when using mock data.

The handler was passing the raw Mirage queryParams object directly to filterResults.
Because queryParams includes pagination keys (limit, offset, sortBy) that have no
corresponding field on ProcessPairsResponse records, filterResults rejected every item —
returning an empty array with timeRangeCount: 0, which disabled the tab.

The fix switches to extractQueryParams(url) and spreads the result into filters, keeping
only the domain filter keys (sourceId, destinationId) that actually exist on the records.

How to test

  1. Start the app in mock mode (yarn start)
  2. Navigate to the Processes list and click any process
  3. Verify the Data links tab is enabled and shows process pairs

Screenshots

Reference (currencyservice-ccb8d746-5h4lj):
image

Before:
image

After:
image

image

@pierpman pierpman added the bug Something isn't working label Oct 2, 2026
@pierpman pierpman linked an issue Oct 5, 2026 that may be closed by this pull request
@pierpman
pierpman merged commit dcdef75 into skupperproject:main Oct 5, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Data links" tab disabled in Process details when using mock data

2 participants