Repository navigation
fix: 🐞 "Data links" tab in Process details using mock data - #609
Merged
Merged
Conversation
pwright
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix the
getProcessPairsmock handler inmocks/server.API.tsto prevent the "Data links"tab from being permanently disabled on Process detail pages when using mock data.
The handler was passing the raw Mirage
queryParamsobject directly tofilterResults.Because
queryParamsincludes pagination keys (limit,offset,sortBy) that have nocorresponding field on
ProcessPairsResponserecords,filterResultsrejected every item —returning an empty array with
timeRangeCount: 0, which disabled the tab.The fix switches to
extractQueryParams(url)and spreads the result intofilters, keepingonly the domain filter keys (
sourceId,destinationId) that actually exist on the records.How to test
yarn start)Screenshots
Reference (currencyservice-ccb8d746-5h4lj):

Before:

After:
