Skip to content

chore: 🔨 Update dependencies - axios - #606

Merged
pierpman merged 1 commit into
skupperproject:mainfrom
pierpman:fix/deps/190_1
Oct 9, 2026
Merged

pierpman merged 1 commit into
skupperproject:mainfrom
pierpman:fix/deps/190_1

Conversation

@pierpman

Copy link
Copy Markdown
Contributor

Description

This PR updates the axios dependency from version 1.16.1 to 1.20.0.

Additional context (optional)

This is a minor version bump for the axios HTTP client library. The update from 1.16.1 to 1.20.0 may include bug fixes, security patches, and new features introduced across the intermediate releases. It is recommended to review the axios changelog for a full list of changes between these versions.

A new commit has been added to this PR.

How to test

  1. Ensure all dependencies are installed by running:
    yarn install
  2. Verify the correct version of axios is installed:
    yarn list --pattern axios
    Confirm the output shows axios@1.20.0.
  3. Run the existing test suite to ensure no regressions:
    yarn test
  4. Manually smoke test any features or flows in the application that rely on HTTP requests to confirm they still function as expected.
  5. Verify the application builds successfully:
    yarn build

@pierpman pierpman added the dependencies Pull requests that update a dependency file label Sep 24, 2026

@pwright pwright left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need reviews on dependency updates?

@pierpman

pierpman commented Oct 5, 2026

Copy link
Copy Markdown
Contributor Author

@pwright @fgiorgetti @c-kruse as Paul mentioned do we need approval for future dependencies updates?

@fgiorgetti

Copy link
Copy Markdown
Member

@pwright @pierpman what if we add CodeRabbit as well as dependabot here?
Maybe this could help getting dependency updates approved automatically, while others could be reviewed by CodeRabbit.
We could still include CODEOWNERS if we want someone to review particular changes.

@c-kruse

c-kruse commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

@pierpman I don't think we've came up with a codified review requirements process - especially in the console project.

In my opinion, one human's judgement is sufficient for dependency bumps (e.g. were dependabot involved, one approval -> merge; otherwise one of us manually upgrades -> self reviews -> merge if confident), especially for minor version bumps.

TBH coderabbit would probably be more diligent about understanding the detla between axios 1.16 and 1.20 and deciding if it is relevant compared to me.

@pierpman

pierpman commented Oct 9, 2026

Copy link
Copy Markdown
Contributor Author

That makes sense to me. I agree that one human approval should be sufficient for dependency updates, and also CodeRabbit would be a useful addition to the repository.

I was trying to find the best way to update the dependencies. There are quite a few that need updating, so I might group related updates together to avoid creating too many PRs.
Thank you @pwright @fgiorgetti @c-kruse

@pierpman
pierpman merged commit 820f431 into skupperproject:main Oct 9, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants